fix: enhance makeUrlParamsForQuery to prioritize transaction types#257
Merged
gsteenkamp89 merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
Updated the makeUrlParamsForQuery function to handle multiple transaction types (request, assertion, proposal, dispute, settlement) with a clear priority order. Added fallback for edge cases to ensure consistent return values. Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes FE-317
Updated the makeUrlParamsForQuery function to handle multiple transaction types (request, assertion, proposal, dispute, settlement) with a clear priority order. Added fallback for edge cases to ensure consistent return values.
We might want to handle more specific params like
requestHashorproposalHashinstead of the generictransactionHashbut that would require changes in our bots, so for now this should work well.